fix(versions): review findings on PR #193
- A version no longer hides behind an original that duplicates resolve demoted (visible_version_clause, hidden_version_rows). - Recording a link drops the version's faces, CLIP data and clip failures (covers link-at-ingest and link_versions --apply). - The display file must live in the original's library; otherwise the original shows, and PUT /image/versions/display answers 400. - link_new_files looks up hashes in chunks of 500 and logs errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
6135034d09
commit
9f50843479
6 files changed
+402
-47
No files matched your search
@@ -390,13 +390,18 @@ for the `link_versions` binary).
|
||||
date drains never fight the copy. Memories therefore put a standalone version on
|
||||
the original's day.
|
||||
- **Hiding** uses the same reachability rule as `duplicate_of_hash`, with one
|
||||
addition: a version row is hidden only while a row for its original exists *in
|
||||
the current view* (`visible_version_clause`; unscoped = any library). A version
|
||||
whose original was deleted, or lives outside the requested library, shows as a
|
||||
addition: a version row is hidden only while its original is *shown in the
|
||||
current view*: a row exists there and was not demoted by duplicates resolve
|
||||
(`visible_version_clause`; unscoped = any library). A version
|
||||
whose original was deleted, demoted, or lives outside the requested library, shows as a
|
||||
normal photo, so nothing disappears silently. Applied in `/photos` (SQL for the
|
||||
recursive listing, `hidden_version_rows` for the folder walk and tag branch),
|
||||
`/memories` and reels, `/photos/exif`, `/photos/gps-summary`, unified search, the
|
||||
camera counts and the media gauges; `include_versions=true` lists them.
|
||||
- **Display file** is fetched through the original's library, so the display
|
||||
choice only counts when the chosen version has a row there (else the original
|
||||
shows; `PUT /image/versions/display` answers 400). Recording a link also drops
|
||||
the version's `face_detections`, CLIP columns and `clip_failures`.
|
||||
- **Tags and favorites** written or read on a version path bind to the original
|
||||
(`canonical_rel_path` in the tag/favorite DAOs, `get_rel_paths_sharing_content`
|
||||
for reads). Insight generation on a version path runs against the original. A
|
||||
|
||||
Reference in new issue
Block a user