Fix tags all and tags for photo endpoints

src/main.rs

@@ -8,15 +8,15 @@ use diesel_migrations::{embed_migrations, EmbeddedMigrations, MigrationHarness};
 use futures::stream::StreamExt;
 use lazy_static::lazy_static;
 use prometheus::{self, IntGauge};
+use std::error::Error;
 use std::sync::mpsc::channel;
+use std::sync::Mutex;
 use std::{collections::HashMap, io::prelude::*};
 use std::{env, fs::File};
 use std::{
     io::ErrorKind,
     path::{Path, PathBuf},
 };
-use std::error::Error;
-use std::sync::Mutex;
 use walkdir::{DirEntry, WalkDir};
 
 use actix_files::NamedFile;
@@ -155,7 +155,7 @@ async fn upload_image(
     if !file_content.is_empty() {
         let full_path = PathBuf::from(&path).join(file_name.unwrap());
         if let Some(full_path) =
-        is_valid_full_path(&app_state.base_path, full_path.to_str().unwrap_or(""))
+            is_valid_full_path(&app_state.base_path, full_path.to_str().unwrap_or(""))
         {
             if !full_path.is_file() && is_image_or_video(&full_path) {
                 let mut file = File::create(full_path).unwrap();
@@ -244,8 +244,13 @@ async fn favorites(
     claims: Claims,
     favorites_dao: Data<Mutex<Box<dyn FavoriteDao>>>,
 ) -> impl Responder {
-    match web::block(move || favorites_dao.lock()
-        .expect("Unable to get FavoritesDao").get_favorites(claims.sub.parse::<i32>().unwrap())).await
+    match web::block(move || {
+        favorites_dao
+            .lock()
+            .expect("Unable to get FavoritesDao")
+            .get_favorites(claims.sub.parse::<i32>().unwrap())
+    })
+    .await
     {
         Ok(Ok(favorites)) => {
             let favorites = favorites
@@ -275,9 +280,12 @@ async fn put_add_favorite(
     if let Ok(user_id) = claims.sub.parse::<i32>() {
         let path = body.path.clone();
         match web::block::<_, Result<usize, DbError>>(move || {
-            favorites_dao.lock().expect("Unable to get FavoritesDao").add_favorite(user_id, &path)
+            favorites_dao
+                .lock()
+                .expect("Unable to get FavoritesDao")
+                .add_favorite(user_id, &path)
         })
-            .await
+        .await
         {
             Ok(Err(e)) if e.kind == DbErrorKind::AlreadyExists => {
                 debug!("Favorite: {} exists for user: {}", &body.path, user_id);
@@ -311,10 +319,13 @@ async fn delete_favorite(
     if let Ok(user_id) = claims.sub.parse::<i32>() {
         let path = body.path.clone();
         web::block(move || {
-            favorites_dao.lock().expect("Unable to get favorites dao").remove_favorite(user_id, path);
+            favorites_dao
+                .lock()
+                .expect("Unable to get favorites dao")
+                .remove_favorite(user_id, path);
         })
-            .await
-            .unwrap();
+        .await
+        .unwrap();
 
         info!(
             "Removing favorite \"{}\" for userid: {}",
@@ -430,8 +441,7 @@ fn main() -> std::io::Result<()> {
     dotenv::dotenv().ok();
     env_logger::init();
 
-    run_migrations(&mut connect())
-        .expect("Failed to run migrations");
+    run_migrations(&mut connect()).expect("Failed to run migrations");
 
     create_thumbnails();
     watch_files();
@@ -475,24 +485,28 @@ fn main() -> std::io::Result<()> {
                 .service(
                     web::resource("image/tags")
                         .route(web::post().to(add_tag::<SqliteTagDao>))
-                        .route(web::get().to(get_all_tags::<SqliteTagDao>))
                         .route(web::get().to(get_tags::<SqliteTagDao>))
                         .route(web::delete().to(remove_tagged_photo::<SqliteTagDao>)),
                 )
+                .service(web::resource("image/tags/all").route(web::get().to(get_all_tags::<SqliteTagDao>)))
                 .app_data(app_data.clone())
                 .app_data::<Data<Mutex<SqliteUserDao>>>(Data::new(Mutex::new(user_dao)))
-                .app_data::<Data<Mutex<Box<dyn FavoriteDao>>>>(Data::new(Mutex::new(Box::new(favorites_dao))))
+                .app_data::<Data<Mutex<Box<dyn FavoriteDao>>>>(Data::new(Mutex::new(Box::new(
+                    favorites_dao,
+                ))))
                 .app_data::<Data<Mutex<SqliteTagDao>>>(Data::new(Mutex::new(tag_dao)))
                 .wrap(prometheus.clone())
         })
-            .bind(dotenv::var("BIND_URL").unwrap())?
-            .bind("localhost:8088")?
-            .run()
-            .await
+        .bind(dotenv::var("BIND_URL").unwrap())?
+        .bind("localhost:8088")?
+        .run()
+        .await
     })
 }
 
-fn run_migrations(connection: &mut impl MigrationHarness<Sqlite>) -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
+fn run_migrations(
+    connection: &mut impl MigrationHarness<Sqlite>,
+) -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
     connection.run_pending_migrations(MIGRATIONS)?;
 
     Ok(())
@@ -515,10 +529,10 @@ fn watch_files() {
                         let image_base_path = PathBuf::from(env::var("BASE_PATH").unwrap());
                         let image_relative = orig.strip_prefix(&image_base_path).unwrap();
                         if let Ok(old_thumbnail) =
-                        env::var("THUMBNAILS").map(PathBuf::from).map(|mut base| {
-                            base.push(image_relative);
-                            base
-                        })
+                            env::var("THUMBNAILS").map(PathBuf::from).map(|mut base| {
+                                base.push(image_relative);
+                                base
+                            })
                         {
                             if let Err(e) = std::fs::remove_file(&old_thumbnail) {
                                 error!(